Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageImport status conditions must be an slice #12

Closed
ricardomaraschini opened this issue Mar 14, 2022 · 1 comment · Fixed by #18
Closed

ImageImport status conditions must be an slice #12

ricardomaraschini opened this issue Mar 14, 2022 · 1 comment · Fixed by #18
Assignees
@ricardomaraschini
Labels
enhancement-proposal-request good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ricardomaraschini
Copy link
Contributor

Condition now specified as a single metav1.Condition. It should be migrated to a slice of conditions so we can easily add extra conditions later on.

See here
@ricardomaraschini ricardomaraschini changed the title ImageImport conditions must be an slice ImageImport status conditions must be an slice Mar 14, 2022
@ricardomaraschini
Copy link
Contributor Author

See discussion shipwright-io/community#57 (comment)

@SaschaSchwarze0 SaschaSchwarze0 added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Mar 14, 2022
@ricardomaraschini ricardomaraschini self-assigned this Mar 16, 2022
@ricardomaraschini ricardomaraschini mentioned this issue Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardomaraschini ricardomaraschini

Labels
enhancement-proposal-request good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using slice of conditions and adding shortNames
2 participants
@ricardomaraschini @SaschaSchwarze0