Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] v0.12.0 does not ship an exact match of build v0.12.0 #184

Closed
1 task done
adambkaplan opened this issue Jan 12, 2024 · 4 comments · Fixed by #182
Closed
1 task done

[BUG] v0.12.0 does not ship an exact match of build v0.12.0 #184

adambkaplan opened this issue Jan 12, 2024 · 4 comments · Fixed by #182
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@adambkaplan
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Kubernetes Version

1.26

Shipwright Version

v0.12.0

Current Behavior

The release.yaml manifest in kodata does not match what is published on the corresponding GitHub release. This makes it challenging to identify future updates to the release manifest.

Expected Behavior

release.yaml for the operator should closely match release.yaml published on GitHub.

Steps To Reproduce

No response

Anything else?

When attempting to update release.yaml so that it aligns with the published version, unit and e2e tests fail. See #182

@adambkaplan adambkaplan added the kind/bug Categorizes issue or PR as related to a bug. label Jan 12, 2024
@jkhelil jkhelil mentioned this issue Feb 5, 2024
4 tasks
@adambkaplan adambkaplan added this to the release-v0.13.0 milestone Mar 28, 2024
@adambkaplan
Copy link
Member Author

Root causes of this issue:

  • Our release.yaml has large CRDs (build APIs have multiple versions)
  • The library we use to deploy release.yaml does not support server-side apply (see Server-Side Apply manifestival/manifestival#102). Without this, Kubernetes adds a "last applied configuration" annotation that effectively duplicates the contents of the CRD.

For v0.12.0, this was fixed by manually crafting a release.yaml that removed the description fields from our CRDs (which can be quite lengthy).

Until manfiestival supports server-side apply, we can work around this by adding a Transform function that truncates the description fields in the CRDs.

@adambkaplan
Copy link
Member Author

This issue is going to block #181 (or we need to craft a release.yaml which strips out the descriptions of CRD fields).

@qu1queee
Copy link

qu1queee commented Apr 4, 2024

From refinement, where are we with this one @adambkaplan .

@adambkaplan
Copy link
Member Author

Updated status - we merged #204 which should unblock us from using the release.yaml from the v0.12.0 release.

Alternatively, we use the v0.13.0 release candidate manifest, thereby allowing us to work on #181 (at the same time?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment