Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a workspace named source for custom tasks #26

Open
SaschaSchwarze0 opened this issue Feb 6, 2023 · 0 comments
Open

Support a workspace named source for custom tasks #26

SaschaSchwarze0 opened this issue Feb 6, 2023 · 0 comments

Comments

@SaschaSchwarze0
Copy link
Member

SaschaSchwarze0 commented Feb 6, 2023

Custom tasks in Tekton allow to specify workspaces. We should allow to pass a workspace with the name source and reject all other workspaces.

The source workspace should be passed to the BuildRun and from there to the Tekton TaskRun that implements the BuildRun. And here it becomes interesting as we will need an extension in Shipwright Build. To be designed, but two options:

  • generic volume support for the source, not my favorite
  • we introduce a source type PipelineWorkspace. In this case, Shipwright will look at the Run/CustomRun which owns the BuildRun. There it should find the workspace named source. And then it will need to look in the owner again which is the PipelineRun to determine what backs the workspace. And then we use this. Interesting will be how we support the affinity assistant capability of Tekton which will be needed if the user uses a PVC which is backed by a hostpath.

Tekton docs: https://tekton.dev/docs/pipelines/customruns/#specifying-workspaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant