Chapter 2 Season 7 replays hang

[stevegee58]

The replay files in season 7 cause the parser to hang. No errors are printed.

[BenTheWood]

Had the same issue so I looked into it and found the problem.

The _logger variable on line 1304 of Unreal.Core/ReplayReader.cs is missing its null check. After adding the check the replays seems to be read correctly.

[stevegee58]

Interesting. It looks like the _logger member variable is being correctly filled in by the constructor from ConsoleReader/Program.cs where it's newed. Maybe the code paths that call the logger weren't even being visited before.

I'll check further when I get home.

[Shiqan]

I think this commit is needed: 5d01ae5

You should check out SL-x-TnT's fork, it contains this fix and is much (much) faster.

[stevegee58]

I switched to the feature/net5 branch and rebuilt and it works now.