Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatization of labels in GitHub Actions #11

Closed
Erick11293 opened this issue Sep 19, 2023 · 11 comments
Closed

Automatization of labels in GitHub Actions #11

Erick11293 opened this issue Sep 19, 2023 · 11 comments
Assignees

Comments

@Erick11293
Copy link
Collaborator

Erick11293 commented Sep 19, 2023

Follow the gentzkow#84 (comment).

@ShiqiYang2022
Copy link
Owner

ShiqiYang2022 commented Sep 21, 2023

@Erick11293 How is it going? Shall we wrap up this by the end of the week? Thanks!!

@ShiqiYang2022
Copy link
Owner

Oh actually github is much more efficient than slack.

@Erick11293
Copy link
Collaborator Author

I completely agree. I'll work on this at the end of the day. Tomorrow, I'll get an update.

@ShiqiYang2022
Copy link
Owner

ShiqiYang2022 commented Sep 21, 2023

Perfect! Love you 🐍

Let me know when you need me to test this new automation on my end.

@ShiqiYang2022
Copy link
Owner

ShiqiYang2022 commented Sep 22, 2023

I am wondering apart from what we already updated, can we let the workflow itself to identify whether this is a blank repo. If this is a blank repo, we can push directly. If not, we can do as what we have now in Github Action, clone, checkout and push.

@Erick11293
Copy link
Collaborator Author

@ShiqiYang2022 I had the same idea, and I tried to do that on my test on Monday. Sadly, I think github actions are not allowed to create branches, or at least not using the code we have your instructions. We can explore this option if we have time.

@ShiqiYang2022
Copy link
Owner

@Erick11293 I think I have complete the upgrading Wiki, see here, to make it clearer to implement. Do you have time to do a test tomorrow on the Automation part strictly follow the new instructions? I think 1 hour at most would be enough.

Thanks!

@ShiqiYang2022
Copy link
Owner

Per conversation, @jc-cisneros will test the newly updated automation process using his template. Ideally it will work(and it should work!). Feel free to put comments here(informal comment is very acceptable and welcomed!). Ideally we shall not spend no more than 1 hour.

Thanks chief! 👑

@jc-cisneros
Copy link
Collaborator

@ShiqiYang2022 per our conversations in Slack, now the process is working in both directions. Great work!
I do think the setup process is still not trivial. I would particularly add more explicit details on the SSH section.

Some minor points:

  • We currently get both "success"/"failed" messages for the Actions even if it is working as expected.
  • An annoying side effect of the previous point, is that I get bombarded by e-mails. I considerable subset of those are actually inaccurate.

@ShiqiYang2022
Copy link
Owner

@jc-cisneros Thanks for your time to test!

I agree 100% we should make the setup process more clear and it's exactly the purpose of testing. I have updated the new instructions here. If you have time could you please take a look at it?

@ShiqiYang2022
Copy link
Owner

Close this issue as completed.

Summary:

Final delivarble can be found here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants