Archive Handler chokes on upload. (Current Master and Dev branches)

[greysondn]

Edit: See the update below. The following bit is kept as a matter of record, and the apparent fix - although in staging - still needs merged.

---

There's a bit of logs from the Freenode IRC, for starters.

[15:45] == greysondn [b80f3f36@gateway/web/freenode/ip.184.15.63.54] has joined #shimmie
[15:46] <greysondn> lo room. anyone got a few minutes to try to tackle an issue I'm having with zip archive uploads? Will post log in a moment.
[15:48] <greysondn> Log entry: https://pastebin.com/fpxTwM50
[15:48] <greysondn> That was my sanity test zip after updating my server. This has happened with multiple zip files.
[16:04] <greysondn> I've grabbed the latest dev branch version, will test momentarily. I think I was on stable, can't swear to it. Also can't be here all day so I may drop out before anyone get to it.
[16:27] <greysondn> can confirm problem in dev.
[17:04] <greysondn> Yeah, it's pretty borked. I'mma give up trying
[17:04] <greysondn> A related problem was found in the mass uploader; most likely the tags aren't being properly expanded for the tagger.
[17:04] <greysondn> https://github.com/shish/shimmie2/issues/575
[17:05] <greysondn> I'll file an issue backtracking to this bit of chat "soon".

As noted, this seems - at least on the surface - to have similarities with #575 . The tag manager doesn't like the tags. I don't speak PHP and don't swear to know, but if I had to bet, the fix exists and only needs integrated properly.

Data about my environment can be made available upon request; however, I am not online often these days. I host Shimmie locally to manage my personal porn stash. While I'm here, great work! Do keep it up!

---

Update:

pull #611 seems to fix the first part of the problems with the archive uploader. In Master, a new issue develops: https://pastebin.com/tw2hfzPi

I am preparing to test Dev. Many thanks to chat's Frogging101 (not sure of dev handle on github) for help this far.

[greysondn]

Can confirm same behavior from updated section in Dev branch, toying around a bit.

[greysondn]

Fix tested and working in dev branch.

File pointer:
https://github.com/shish/shimmie2/blob/develop/ext/handle_archive/main.php#L37

Delete that conditional block and everything behaves just fine. This file evidently has no theme, which causes the second part of this issue.

These two steps to fix the issue are credit to @Frogging101 and his/her patient work with me in the IRC tracking it down. PHP is not my language or I'd offer the patch to upstream. Credit for the fix goes to Frogging; credit for the initial testing of the fix I'll take.

Again, thanks for all your hard work, guys!

[jgen]

Thanks both @greysondn @Frogging101! :)
Pull-request #613 adds a check to see if the theme has an add_status() method before trying to call it. This should hopefully resolve the issue.

[Frogging101]

Great! Happy to help :)

[greysondn]

:D Okay then. Glad to see work done.