Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype pollution by Opal #3

Closed
shishkin opened this issue Jul 27, 2023 · 0 comments
Closed

Prototype pollution by Opal #3

shishkin opened this issue Jul 27, 2023 · 0 comments

Comments

@shishkin
Copy link
Owner

It seems that running Asciidoctor.js does pollute Javascript native object prototypes that leads to weird bugs. For example, this code adds a stub $id method to Array prototype so all arrays suddenly get it:

import asciidoctor from "@asciidoctor/core";

asciidoctor();

console.log([].$id);
// [Function: method_missing_stub] { '$$stub': true }
console.log(Array.prototype.$id);
// [Function: method_missing_stub] { '$$stub': true }

I discover a bug with this in ajv schema validator that runs into issues when it encounters an array of schemas with a present $id property, which it only expects to find on a single schema, not array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant