feat: add scores #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks for this, it was fun to play with:D I added auto restart because it seemed a little annoying for both clients to reconnect after each game. But you don't have to merge this - it can stay as a reference for the curious (I assume you'd like to keep the byte size small:D) Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
depends on: #1 refactored to use `c.o` as connection.other instead of keeping track of separate write methods and scores, since using references to keep scores avoids the need to update it in 2 places, which automatically avoids bugs Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on: #1
refactored to use
c.oas connection.other instead of keeping track ofseparate write methods and scores, since using references to keep scores
avoids the need to update it in 2 places, which automatically avoids bugs