Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting warning regaring pecl #141

Closed
ADmad opened this issue Jan 6, 2020 · 9 comments · Fixed by #144
Closed

Getting warning regaring pecl #141

ADmad opened this issue Jan 6, 2020 · 9 comments · Fixed by #144

Comments

@ADmad
Copy link

ADmad commented Jan 6, 2020

Error message

##[warning]Input 'pecl' has been deprecated with message: The pecl property will not be supported after February 1, 2020. Specify pecl in tools instead.

https://github.com/cakephp/cakephp/pull/14129/checks?check_run_id=375597868#step:4:1

@ADmad
Copy link
Author

ADmad commented Jan 6, 2020

Apologies, I can fix the error by following the error message :)

@ADmad ADmad closed this as completed Jan 6, 2020
@shivammathur
Copy link
Owner

Yes, specify pecl in the tools input

@ADmad
Copy link
Author

ADmad commented Jan 6, 2020

Is this config change required due to change in some external tool / service?

@shivammathur
Copy link
Owner

No, I added support for installing various tools globally via tools input. Please see, so it made sense to refactor pecl installation in that instead of a separate input for it.

@ADmad
Copy link
Author

ADmad commented Jan 6, 2020

I find it strange that you are forcing users to update their config before a deadline. Since github actions are versioned wouldn't it more prudent to simply release a new major version if your script has a breaking change? That way using using v1 wouldn't need to make any change.

@shivammathur
Copy link
Owner

shivammathur commented Jan 6, 2020

The change currently is not a breaking one, it is just a warning that some inputs have been deprecated and at this point old inputs will function just like they used to. I added this warning because many projects use master and changing inputs suddenly without warning will be abrupt.

The date mentioned in the warning is around the time I plan to release v2 and remove support for old inputs in that, which will be a breaking change.

@ADmad
Copy link
Author

ADmad commented Jan 6, 2020

Okay, in that cause a message like The 'pecl' property will be removed in v2 would have made more sense rather than specifying a date IMHO.

@shivammathur
Copy link
Owner

ok. I will make these more clear in the next release.

@ADmad
Copy link
Author

ADmad commented Jan 6, 2020

Thank you.

@shivammathur shivammathur mentioned this issue Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants