Corrupted composer is installed using v1

[stof]

Describe the bug
Things where working fine yesterday in the afternoon. But workflows running yesterday evening (19:35 UTC+2) installed a corrupted version of composer (without the setup-php step reporting a failure, so the failure was only reported by a later step using composer)

Version

• I have checked releases and the bug exists in the latest patch version of v1 or v2.
• v2
• v1

I haven't checked v2

Runners

• GitHub Hosted
• Self Hosted

Operating systems
linux

PHP versions
7.3

To Reproduce

jobs:
  phpstan:
    name: PHPStan
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2
      - name: Setup PHP
        uses: shivammathur/setup-php@v1
        with:
          php-version: 7.3
          extensions: intl
          coverage: none
      # more steps following, where using composer would throw the same fatal error and break the build

Expected behavior
A usable version of composer is installed.
And another expectation would be that such fatal error actually makes the setup report a failure rather than failing silently.

Screenshots/Logs
Here is the output of the setup-php step:

 Setup PHP
24s
    coverage: none
Run shivammathur/setup-php@v1
  with:
    php-version: 7.3
    extensions: intl
    coverage: none
/bin/bash /opt/hostedtoolcache/linux.sh 7.3 /home/runner/work/_actions/shivammathur/setup-php/v1/dist

==> Setup PHP
✓ PHP Switched to PHP 7.3.19

==> Setup Tools
PHP Fatal error:  Uncaught PharException: internal corruption of phar "/usr/local/bin/composer" (truncated manifest header) in /usr/local/bin/composer:23
Stack trace:
#0 /usr/local/bin/composer(23): Phar::mapPhar('composer.phar')
#1 {main}
  thrown in /usr/local/bin/composer on line 23
✓ composer Added

==> Setup Extensions
✓ intl Enabled

==> Setup Coverage
✓ none Disabled Xdebug and PCOV

Additional context

Are you willing to submit a PR?

[mfn]

@shivammathur
I had just the same happen to me too:

Can't there be some exit code check added to break this GHA step if the setup couldn't finish properly?

[shivammathur]

@mfn Added, will be there in next release.

[mfn]

Wow, I saw the commit 82a0dd8 . So much work what I thought would be just an exit somewhere.

Much appreciated 🙇

[shivammathur]

Also improved how different versions of composer are setup, so most of 82a0dd8 is that.

[shivammathur]

@mfn @stof After 2.4.0 release if composer does not download correctly, setup will fail with the message "Could not download composer".

[mfn]

Awesome, will try it out!

😼