Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme not working properly for some PDFs #16

Open
Oliver-Haynes opened this issue May 14, 2024 · 3 comments
Open

Dark theme not working properly for some PDFs #16

Oliver-Haynes opened this issue May 14, 2024 · 3 comments

Comments

@Oliver-Haynes
Copy link

image
when trying to apply the firefox theme only the area behind the text changes,but when using the regular dark theme it works fine
image

@shivaprsd
Copy link
Owner

shivaprsd commented May 16, 2024

Hi @Oliver-Haynes, probably this PDF has a big white image behind the text. Can you attach the PDF, so that I can try to reproduce the issue? Thanks!

@shivaprsd shivaprsd added the question Further information is requested label May 16, 2024
@Oliver-Haynes
Copy link
Author

Hi @Oliver-Haynes, probably this PDF has a big white image behind the text. Can you attach the PDF, so that I can try to reproduce the issue? Thanks!

https://madasmaths.com/archive/iygb_practice_papers/fp2_practice_papers/fp2_w.pdf
not the same pdf but from the same place

@shivaprsd
Copy link
Owner

shivaprsd commented May 18, 2024

@Oliver-Haynes Yes, the PDF has a big all-white rectangular image (almost covering the page) behind the text (probably to include the vertical watermark on either sides). You can verify this by toggling the Blend Images option in the toolbar (click the ⚙️ icon near the theme name to reveal it), you can see it even in the light theme.

Some PDF apps create PDFs this way, which is sad, and the best we can do is to invert the image. But then it is nearly the same as using the "regular dark theme" (which actually is just inverting the page colours).

@shivaprsd shivaprsd removed the question Further information is requested label May 18, 2024
@shivaprsd shivaprsd changed the title firefox theme not working properly Dark theme not working properly for some PDFs May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants