New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS_verify is horribly broken. #132
Comments
Did a little digging, the first exception occurs because the TLS implementation in pydle is incorrect and needs to be redone. Not sure what is going on with the second exception but the two are likely related. the
Looks like #84 and #70 solve the problem by removing the validation step entirely. I am not comfortable with doing this, especially since one can pass As a workaround while I (or someone beating me to it) hopefully fixes the TLS implementation you can, for the moment, ask Pydle not to validate the TLS cert by passing |
@theunkn0wn1 Are you sure #84 doesn't fix this? It sets
Got curious and tested this myself: https://0x0.st/izWV.py I think #84 is the right fix. |
Interesting, that does look to do correctly exactly what the current implementation fails to do. Sorry for the delay on this, Classes have been taking more time than expected 🤦♂️ . I will verify #84 tonight (~12 hours) and prepare a release. |
version 0.9.4rc1 is now released. |
It errors out (on my system, Windows 10 x64) with the following tracebacks:
and
I notice 2 open PRs (#84 and #70) trying to fix it, but don't know for sure if they work. The ability to confirm the server's certs/TLS feels like it should either not fail horribly, or it shouldn't be there at all.
The text was updated successfully, but these errors were encountered: