Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env vars to docker images #89

Open
sudo-Tiz opened this issue Jan 27, 2024 · 3 comments
Open

Add env vars to docker images #89

sudo-Tiz opened this issue Jan 27, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@sudo-Tiz
Copy link

sudo-Tiz commented Jan 27, 2024

The usage of CLI arguments works well for binary usage but with docker images it would be better to propose environments variables.
We could imagine something like:
cli_args if not undefined else anv_agrs if not undefined else default

@shizunge
Copy link
Owner

For my education, is there a use case that can be only done via env, not cli argument?

@shizunge shizunge added the enhancement New feature or request label Jan 28, 2024
@sudo-Tiz
Copy link
Author

Well, this is a common practice to use environment variables with container orchestration tools. This way you can set the necessary environment variables once and reuse them across different instances or containers instead of passing CLI arguments every time.
I admits this is not mandatory at all and a configuration file would be better (see #88 )

@sudo-Tiz sudo-Tiz closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2024
@shizunge
Copy link
Owner

Share Env is a legit use case. Let us keep this issue open

@shizunge shizunge reopened this Jan 28, 2024
Repository owner deleted a comment from Soumya6Tiwari Feb 23, 2024
Repository owner deleted a comment from Soumya6Tiwari Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants