Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Shlink 4.0.0 #72

Closed
6 tasks done
acelaya opened this issue Feb 28, 2024 · 0 comments · Fixed by #78
Closed
6 tasks done

Support Shlink 4.0.0 #72

acelaya opened this issue Feb 28, 2024 · 0 comments · Fixed by #78
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Feb 28, 2024

  • Short URL redirect rules
  • Mark visitsCount props as optional and deprecated
    • For backwards compatibility, define types so that either visitsSummary or visitsCount is defined. That will avoid doing visitsSummary?.total ?? visitsCount ?? 0 wehere we were previously doing visitsSummary?.total ?? visitsCount.
      This does not work as expected, and the later is still required, which is unfortunate.
      We'll have to keep the least ergonomic approach until all VisitsSummary props can be defined as non-optional due to dropping older Shlink versions support.
  • Mark deviceLongUrls as deprecated
  • Filter orphan visits by type
  • Mark ErrorTypeV2 and ErrorTypeV3.INVALID_URL as deprecated
@acelaya acelaya changed the title Support Shrink 4.0.0 Support Shlink 4.0.0 Feb 28, 2024
@acelaya acelaya added this to the 1.0.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant