Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with city statistics on high view links #118

Closed
jakkuh opened this issue Mar 5, 2019 · 3 comments
Closed

Bug with city statistics on high view links #118

jakkuh opened this issue Mar 5, 2019 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jakkuh
Copy link

jakkuh commented Mar 5, 2019

Have a weird bug / crash with a link with 50k visits and a ton of different cities.

https://i.imgur.com/A9wdXbe.png

See the side bar, it must be several thousand lines long... seems to need pagination :P
https://i.imgur.com/Nd7Xh61.png

note: it doesn't result in any errors in the console.

@acelaya
Copy link
Member

acelaya commented Mar 5, 2019

Oh, we are probably hitting some limit here, either on the native rendering of SVGs or something in the abstraction library (which is chart.js, by the way).

I'm not really sure how to "paginate" this, but I will try to come up with something.

@acelaya acelaya added the bug Something isn't working label Mar 5, 2019
@acelaya acelaya added this to the 2.0.3 milestone Mar 5, 2019
@acelaya acelaya self-assigned this Mar 5, 2019
@acelaya
Copy link
Member

acelaya commented Mar 16, 2019

I have implemented a client-side pagination that will allow you to just render part of the dataset.

You can see the behavior here https://www.youtube.com/watch?v=DbTt1v21rcs

This also sort of fixes #119, since the map now allows displaying only pins for the cities in the active page when pagination is enabled.

This is part of v2.0.3, which is already released, and will be published in https://app.shlink.io in the next hour/s

@acelaya
Copy link
Member

acelaya commented Mar 16, 2019

The only thing left is that, if the amount of pages is too big, the pagination component might overlap with the chart, since it is sticky.

Let me know if that's the case, and I will try to make it render with ellipsis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants