Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pagination controls display only the amount of pages that fit one row #157

Closed
jakkuh opened this issue Sep 20, 2019 · 2 comments · Fixed by #158
Closed

Make pagination controls display only the amount of pages that fit one row #157

jakkuh opened this issue Sep 20, 2019 · 2 comments · Fixed by #158
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jakkuh
Copy link

jakkuh commented Sep 20, 2019

Currently when paginating the cities tab in analytics, if you have a large number of unique cities, this happens: https://i.imgur.com/RFbIvUj.png

That's a 150k visit's link.

I think something like the way Google's search results handles it would work well. https://i.imgur.com/TZqBXEI.gifv

It would also be helpful to display like "Page x of y" so you know how far the list extends. 'x' being the current page number, with 'y' as the total number of pages.

@acelaya
Copy link
Member

acelaya commented Sep 21, 2019

Ok, that's definitely not nice and will be fixed.

@acelaya acelaya changed the title Feature Request: Pagination # Grouping Make pagination controls display only the amount of pages that for one row Sep 21, 2019
@acelaya acelaya changed the title Make pagination controls display only the amount of pages that for one row Make pagination controls display only the amount of pages that fit one row Sep 21, 2019
@acelaya acelaya transferred this issue from shlinkio/shlink Sep 21, 2019
@acelaya acelaya added the bug Something isn't working label Sep 21, 2019
@acelaya acelaya modified the milestones: 2.2.0, 2.1.1 Sep 21, 2019
@acelaya acelaya self-assigned this Sep 21, 2019
@acelaya
Copy link
Member

acelaya commented Sep 22, 2019

@tivyhosting how does this look.

ezgif-3-e629c040e360

This ensures only a few page controls to be rendered at the same time, but you also know how many pages there are.

(I just set an option with 2 items per page to force a lot of pages to be rendered, but that won't be part of the release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants