Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR Modal Link Wrapping #417

Closed
antwonw opened this issue May 6, 2021 · 3 comments · Fixed by #418
Closed

QR Modal Link Wrapping #417

antwonw opened this issue May 6, 2021 · 3 comments · Fixed by #418
Assignees
Labels
bug Something isn't working
Milestone

Comments

@antwonw
Copy link
Contributor

antwonw commented May 6, 2021

This line in the CSS specifically states to not wrap the QR Code hyperlink in the QR modal.

.indivisible {
white-space: nowrap;
}

This results in really bad design behavior.

Screen Shot 2021-05-06 at 4 33 31 PM

Removing these lines fixes the problem.

Screen Shot 2021-05-06 at 4 33 50 PM

@antwonw
Copy link
Contributor Author

antwonw commented May 6, 2021

After review, removing the indivisible class wholly, would break other instances where nowrap is needed.

Instead, the indivisible class should be removed from this line.

<ExternalLink className="indivisible" href={qrCodeUrl} />

@antwonw
Copy link
Contributor Author

antwonw commented May 7, 2021

I have created a pull request (#418) to review which removes className="indivisible" from QrCodeModal.tsx.

@acelaya acelaya added this to the 3.1.1 milestone May 7, 2021
@acelaya acelaya added the bug Something isn't working label May 7, 2021
@acelaya
Copy link
Member

acelaya commented May 7, 2021

Nice catch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants