Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow time to be specified when setting limit for link to be enabled #717

Closed
kouyk opened this issue Oct 16, 2022 · 4 comments · Fixed by #720
Closed

Allow time to be specified when setting limit for link to be enabled #717

kouyk opened this issue Oct 16, 2022 · 4 comments · Fixed by #720
Labels
Milestone

Comments

@kouyk
Copy link

kouyk commented Oct 16, 2022

Summary

Currently the web client allows the user to control when the link is enabled, but only the date can be specified. From a brief look at the API, the granularity allows for the time to be specified as well. Is it possible for this to be exposed in the web client as well?

@kouyk kouyk added the feature label Oct 16, 2022
@acelaya
Copy link
Member

acelaya commented Oct 16, 2022

I need to check if the API actually honors provided time (I'm almost sure it does, but this was implemented long ago).

If so, yes, supporting this should be possible, as the date component supports time as well.

@acelaya acelaya added this to the 3.8.0 milestone Oct 16, 2022
@acelaya
Copy link
Member

acelaya commented Oct 17, 2022

I can confirm Shlink does indeed support this already. It just requires the changes in the UI.

@acelaya
Copy link
Member

acelaya commented Oct 23, 2022

How do these look:

The time component will allow you to pick in 10 minute intervals.

@kouyk
Copy link
Author

kouyk commented Oct 23, 2022

How do these look:

* Dark theme: https://youtu.be/w6vb3du7mHg

* Light theme: https://youtu.be/dDQ7Lwibvgo

The time component will allow you to pick in 10 minute intervals.

Looks great, 10 minute intervals should be sufficient granularity under most circumstance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants