Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplicated code on visits components and reducer #11

Closed
acelaya opened this issue Feb 5, 2022 · 1 comment
Closed

Reduce duplicated code on visits components and reducer #11

acelaya opened this issue Feb 5, 2022 · 1 comment
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Feb 5, 2022

There's currently a few sets of components and reducers to handle visits:

  • Short URL visits
  • Tag visits
  • Orphan visits
  • Non-orphan visits
  • Domain visits (TBD)

All of them have a relatively close handling, as the UI has only small variations.

Currently there's a couple of helper functions used to reduce code duplication, but there's still room for improvement.

Try to find a way to reduce duplicated code (specially on tests), without making it even more complex to understand.

@acelaya acelaya transferred this issue from shlinkio/shlink-web-client Aug 14, 2023
@acelaya acelaya added this to the 0.4.0 milestone Aug 19, 2023
@acelaya acelaya modified the milestones: 0.4.0, 1.0.0 Sep 25, 2023
@acelaya
Copy link
Member Author

acelaya commented Jan 29, 2024

As part of #7 and #9, there have been many refactors, so I'm closing this as completed

@acelaya acelaya modified the milestones: 1.0.0, 0.5.0 Jan 29, 2024
@acelaya acelaya closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant