New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid downloading GeoLite2 database if DISABLE_IP_TRACKING #1100
Comments
I may attempt a PR for this if it's considered valid. Any pointers from the devs regarding on how to tackle this would be appreciated, too :) |
This is not how it should behave. I'll give it a thought. |
Hey @matiasgarciaisaia. I have just released Shlink v2.7.1 which addresses this. Shlink will no longer try to download the GeoLite db if DISABLE_TRACKING or DISABLE_IP_TRACKING are set to true. Wait until this job finishes (will take around 1h), and then you will be able to pull the docker image. |
Nice PR :) I'll give it a try tomorrow - thanks for taking care of this! |
So if one hasn't disabled IP tracking there's no need to update to this patch release? |
@acelaya the patch works great 👌 @Roy-Orbison per the diff, this is the only change since v2.7.0, so it wouldn't make any difference to upgrade if you have IP tracking enabled. |
Yes @Roy-Orbison, you can skip it, but as @matiasgarciaisaia says, there's no other side effects. Up to you. |
refreshing infra this morning and pulling from :latest broke until I intentionally disabled via the listed switch above hanging on "Downloading GeoLite2 db file..." until I did so... -e DISABLE_TRACKING=true -e DISABLE_IP_TRACKING=true
|
Hey @CPCJ79. As that's a different issue, can you open another ticket? |
Summary
When IP tracking is disabled,
shlink
should avoid trying to get a GeoLite2 database from MaxMind.I'm running
shlinkio/shlink:2.7.0
(currentstable
) locally withDISABLE_IP_TRACKING: 'true'
.Upon my first visit to the root path, shlink tries to download the GeoLite2 database and fails (due to the default license key resulting in a 429 Too Many Requests), even though I've asked shlink to disable IP tracking.
I think shlink should avoid interacting with the GeoLite2 DB at all if geolocating IPs is disabled.
Repro
docker-compose.yml
:Logs:
The text was updated successfully, but these errors were encountered: