Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change original_url field size to use one which allows bigger sizes #1674

Closed
Zaczero opened this issue Jan 21, 2023 · 4 comments · Fixed by #2019
Closed

Change original_url field size to use one which allows bigger sizes #1674

Zaczero opened this issue Jan 21, 2023 · 4 comments · Fixed by #2019
Milestone

Comments

@Zaczero
Copy link

Zaczero commented Jan 21, 2023

Summary

I need to shorten VERY long URLs (which work fine in Firefox/Chromium).
However, I face a Shlink limitation because it doesn't allow for URLs longer than 2048 characters (2KB).
I would love to be able to lift this limitation, for example, during database creation (ENV parameter?).

References

@Zaczero Zaczero changed the title Make it possible to configure the original_url field size (from the default 2048) Configurable original_url field size (default is 2048) Jan 21, 2023
@acelaya
Copy link
Member

acelaya commented Jan 21, 2023

I'm afraid it's not easy to set database params dynamically, in a way that it's not confusing for users which would expect to be able to change that at any point in time (as it happens with the rest of the config options).

I could explore making it the biggest possible text type on every database, but that could have some impact, specially on existing instances, so I need to investigate it a bit further.

@Zaczero
Copy link
Author

Zaczero commented Jan 21, 2023

Major database solutions will only allocate as much space as needed. For example, you can check out the MySQL documentation at https://dev.mysql.com/doc/refman/8.0/en/char.html. The only thing to consider would be the possibility for abuse.

@acelaya acelaya added this to the 3.6.0 milestone Apr 16, 2023
@acelaya acelaya changed the title Configurable original_url field size (default is 2048) Change original_url field size to use one which allows bigger sizes Apr 16, 2023
@acelaya acelaya removed this from the 3.6.0 milestone May 21, 2023
@acelaya acelaya added this to the 4.0.0 milestone Nov 4, 2023
@acelaya
Copy link
Member

acelaya commented Feb 22, 2024

Column type for long URLs has been changed to TEXT, allowing for much longer values.

This change will be released with Shlink 4.0.0

@Zaczero
Copy link
Author

Zaczero commented Feb 22, 2024

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants