Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When trying to create new short URLs with domain, allow to pass the port too #502

Closed
acelaya opened this issue Oct 5, 2019 · 0 comments · Fixed by #515
Closed

When trying to create new short URLs with domain, allow to pass the port too #502

acelaya opened this issue Oct 5, 2019 · 0 comments · Fixed by #515
Labels
bug
Milestone
1.20.0

Comments

@acelaya
Copy link
Member

acelaya commented Oct 5, 2019 •
edited

How Shlink is set-up

  • Shlink Version: 1.19.0
  • PHP Version: All
  • How do you serve Shlink: All
  • Database engine used: All

Summary

When trying to create a new short URL with domain, the domain field is validated as a hostname, making validation fail if the port is provided too.

Change this validation to use HostAndPortValidator from shlink-common, so that the port can be provided as well.

Current behavior

A validation error is thrown if the port is provided as part of the domain field.

Expected behavior

The validation passes as long as the hostname and port are valid.
@acelaya acelaya added the bug label Oct 5, 2019
@acelaya acelaya modified the milestone: 1.20.0 Oct 5, 2019
@acelaya acelaya changed the title When trying to match short URL with domain, use only domain and not authority When trying to match short URL with domain, use only domain instead of authority Oct 5, 2019
@acelaya acelaya changed the title When trying to match short URL with domain, use only domain instead of authority When trying to create new short URLs with domain, allow to pass the port too Oct 20, 2019
@acelaya acelaya added this to the 1.20.0 milestone Oct 20, 2019
@acelaya acelaya mentioned this issue Oct 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Feature/host and port acelaya-forks/shlink
1 participant
@acelaya