Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when generating QR code for ShortUrl with domain #509

Closed
acelaya opened this issue Oct 15, 2019 · 0 comments · Fixed by #516
Closed

Error when generating QR code for ShortUrl with domain #509

acelaya opened this issue Oct 15, 2019 · 0 comments · Fixed by #516
Assignees
@acelaya
Labels
bug
Milestone
1.20.0

Comments

@acelaya
Copy link
Member

acelaya commented Oct 15, 2019 •
edited

How Shlink is set-up

  • Shlink Version: 1.19.0
  • PHP Version: All
  • How do you serve Shlink: All
  • Database engine used: All

Summary

The action generating the QR code always tries to fetch without taking into account the request's domain.

It should fetch the domain in the same way the tracking actions do.
@acelaya acelaya added the bug label Oct 15, 2019
@acelaya acelaya added this to the 1.20.0 milestone Oct 15, 2019
@acelaya acelaya self-assigned this Oct 15, 2019
@acelaya acelaya mentioned this issue Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acelaya acelaya

Labels
bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Feature/qr code with domain acelaya-forks/shlink
1 participant
@acelaya