angular2-modal: EXCEPTION: Uncaught (in promise): undefined #188

kisdaniel · 2016-09-13T09:44:17Z

I get the following error when I close the modal alert:

core.umd.js:6001 Error: Uncaught (in promise): undefined
    at resolvePromise (zone.js:418)
    at PromiseCompleter.reject (zone.js:395)
    at _dismiss (angular2-modal.umd.js:391)
    at eval (angular2-modal.umd.js:394)
    at ZoneDelegate.invoke (zone.js:192)
    at Object.onInvoke (core.umd.js:8772)
    at ZoneDelegate.invoke (zone.js:191)
    at Zone.run (zone.js:85)
    at zone.js:451
    at ZoneDelegate.invokeTask (zone.js:225)

Sample code:

       this.modal.alert()
            .size("lg")
            .showClose(true)
            .title("title")
            .body("message")
            .open();

Dependencies:

"dependencies": {
    "@angular/common": "2.0.0-rc.6",
    "@angular/compiler": "2.0.0-rc.6",
    "@angular/compiler-cli": "0.6.0",
    "@angular/core": "2.0.0-rc.6",
    "@angular/forms": "2.0.0-rc.6",
    "@angular/http": "2.0.0-rc.6",
    "@angular/platform-browser": "2.0.0-rc.6",
    "@angular/platform-browser-dynamic": "2.0.0-rc.6",
    "@angular/router": "3.0.0-rc.2",
    "@angular/upgrade": "2.0.0-rc.6",
    "core-js": "^2.4.1",
    "reflect-metadata": "^0.1.3",
    "rxjs": "5.0.0-beta.11",
    "systemjs": "0.19.27",
    "zone.js": "^0.6.17",
    "angular2-in-memory-web-api": "0.0.18",

    "angular2-modal": "^2.0.0-beta.10",
    "bootstrap": "^3.3.7",
    "font-awesome": "^4.6.3",
    "jquery": "^3.1.0",
    "momentjs": "^1.1.15",
    "ng2-translate": "^2.4.4"
  },

The text was updated successfully, but these errors were encountered:

patriknil90 · 2016-09-13T14:57:33Z

+1
Also with RC6

Error: Uncaught (in promise): undefined at resolvePromise (polyfills.bundle.js:7870) at PromiseCompleter.reject (polyfills.bundle.js:7847) at _dismiss (main.bundle.js:1186) at main.bundle.js:1189 at ZoneDelegate.invoke (polyfills.bundle.js:7649) at Object.onInvoke (vendor.bundle.js:8934) at ZoneDelegate.invoke (polyfills.bundle.js:7648) at Zone.run (polyfills.bundle.js:7542) at polyfills.bundle.js:7903 at ZoneDelegate.invokeTask (polyfills.bundle.js:7682)

AbdulRahmanAlHamali · 2016-09-15T07:55:41Z

This exception is thrown when dismissing the dialog, if a reject function was not supplemented. The exception doesn't really cause any problems. But if you want to get rid of it, from a user perspective, you should make it like:

this.modal.alert().size("lg").showClose(true).title("title").body("message").open().then(result => { result.result.then(() => {}, () => {}); });

From the perspective of the library developer, @shlomiassaf could fix it by checking if the reject function actually exists before trying to call it.

kisdaniel · 2016-09-15T13:22:54Z

the workaround seems to be working by adding .then(result => { result.result.then(() => {}, () => {}); });.

I hope @shlomiassaf will fix it.

JulioC · 2016-09-21T01:39:28Z

I believe it's not possible to check if there is a reject handler for the promise.

A better approach would adding a context config for not rejecting the promise, although I understand that DialogRef shouldn't care about context properties. This means that all context would inherit from a BaseContext.

Paging @shlomiassaf for his view

andyrue · 2016-09-22T01:39:43Z

I think duplicates of #179 and #184.

shlomiassaf · 2016-09-22T23:27:01Z

I'll look into a possible solution.

What about wrapping the resolve/reject call in a try/catch?

JulioC · 2016-09-22T23:44:53Z

AFAIK a try/catch wouldn't help with unhandled rejections, since they don't fire a exception on the .reject() call.

AbdulRahmanAlHamali · 2016-09-23T04:20:00Z

Wouldn't it work if we just say:

if (reject !== undefined)
reject();

What do you think?

On 23 Sep 2016 02:45, "Júlio César" notifications@github.com wrote:

AFAIK a try/catch wouldn't help with unhandled rejections, since they
don't fire a exception on the .reject() call.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#188 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP4ByHCdyAmsDt-nIEOsLuUSHwb0Z82_ks5qsxL3gaJpZM4J7evY
.

kisdaniel · 2016-09-23T07:12:36Z

What do you think about this?

if (typeof reject === "function") {
  reject();
}

shlomiassaf · 2016-09-23T12:21:00Z

@kisdaniel this._resultDeferred.reject is always a function, the problem is due to the reason it does not have an handler, this a known Promise behaviour.

@JulioC You're completely right, I though the promise itself will throw and not the handlers inside, my bad.

I have another proposal, jus before rejecting register a catch handler.

      this.destroy();
      this._resultDeferred.promise.catch(() => {});
      this._resultDeferred.reject();

Usually this is wrong, the library shouldn't mess with the promise chain.
However, I don't see any side effects here.
Thinking Promises, the developer gets the promise object without any handlers, any handler (reject or resolve) that we add to the promise object is added as a ROOT handler so it doesn't effect any handlers registered by the developer.

Each handler from the ROOT is a different chain so I don't see any issues,

To illustrate:

Promise:
               then
                 then
                   catch
               catch
               catch // Catch registered by the library.

The last catch handler is the one registered by the library, all others will also fire, regardless.
Anyway, if we get to this point the developer already registered all his handlers and anyway he has no way of adding more, at this point.

Thoughts?

closes #188

shlomiassaf · 2016-09-23T13:18:11Z

see the suggested PR

JulioC · 2016-09-23T13:57:44Z

I overlooked the fact that the promise could have any amount of catch handlers.

Your solution looks fine, as long this handler is only registered when the dialog is dismissed.

webartistkb · 2016-10-05T22:01:24Z

I still get this when I close the modal (First time)
error_handler.js:51 Error: Uncaught (in promise): undefined
at resolvePromise (zone.js:418)
at PromiseCompleter.reject (zone.js:395)
at _dismiss (dialog-ref.js:65)
at dialog-ref.js:68
at ZoneDelegate.invoke (zone.js:192)
at Object.onInvoke (ng_zone_impl.js:43)
at ZoneDelegate.invoke (zone.js:191)
at Zone.run (zone.js:85)
at zone.js:451
at ZoneDelegate.invokeTask (zone.js:225)

JulioC · 2016-10-06T17:35:53Z

Indeed, it will still throw if you set a resolve callback, but no reject:

modal.open(MyModal);
  .then(dialog => {});

I believe the only possible solution would stop rejecting the promise if the modal is dismissed.

Maybe add a DialogResult structure, which holds the close reason and data, but that means a breaking change...

AbdulRahmanAlHamali · 2016-10-06T17:57:31Z

It would indeed be a very annoying breaking change because most people don't check the result in their Confirm dialogs. In addition the exception is not that problematic. It never caused any bugs for me at least, so I don't think it is worth a breaking change

naveenprincep · 2016-10-12T07:33:53Z

Hi guys, I am also getting this same error. Is there any work around without any breaking changes??

JulioC · 2016-10-12T15:10:14Z

You can still use the workaround above, always provide a reject callback:

modal.open(MyModal)
  .then(dialog => {})
  .catch(() => {}); // this is the workaround

naveenprincep · 2016-10-13T13:00:39Z

#223 fixed my issue. thanks

Romanchuk · 2017-11-15T10:43:52Z

This is still an issue.
Angular 5.0.1
ngx-modialog 4.0.0-beta.3
zone.js 0.8.18

@JulioC workaround works

micheltank · 2017-12-25T01:20:04Z

same problem in angular 5.1.1

micheltank · 2017-12-25T01:34:11Z

I found the problem, need to pass the second param to "then":

dont works:
dialog.result.then((result) => { console.log(result); });

works:

dialog.result.then((result) => { console.log(result); }, () => console.log('Rejected!'));

dbrezoev · 2018-02-15T16:23:22Z

@micheltank the second parameter is supposed to be optional.

bhattbhaskar · 2018-05-11T13:24:29Z

Hi please try to implement this way for dialog

this.modal.confirm()
      	.okBtn("Yes")
      	.cancelBtn("No")
      	.size('sm')
      	.showClose(true)
      	.title('Confirm')
      	.body("Do you want to accept?")
    	.open().then(result => {
       	result.result.then(result=> {
       		console.log('Yes');
       	},() =>
      		console.log('No!');
      	);
    });

This was referenced Sep 23, 2016

Error when closing modal #184

Closed

Vex Modal promise & rxjs error on dialog-ref.close and dialog-ref.dismiss #179

Closed

shlomiassaf pushed a commit that referenced this issue Sep 23, 2016

fix: suppress unhandled rejection

a383762

closes #188

shlomiassaf mentioned this issue Sep 23, 2016

fix: suppress unhandled rejection #203

Merged

shlomiassaf closed this as completed in #203 Sep 23, 2016

sudhishsasi mentioned this issue Sep 29, 2016

Modal not closing Angular 2 version 2.0 + Angular Cli beta 15 #208

Open

shlomiassaf reopened this Oct 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

angular2-modal: EXCEPTION: Uncaught (in promise): undefined #188

angular2-modal: EXCEPTION: Uncaught (in promise): undefined #188

kisdaniel commented Sep 13, 2016

patriknil90 commented Sep 13, 2016

AbdulRahmanAlHamali commented Sep 15, 2016

kisdaniel commented Sep 15, 2016

JulioC commented Sep 21, 2016 •

edited

andyrue commented Sep 22, 2016

shlomiassaf commented Sep 22, 2016

JulioC commented Sep 22, 2016

AbdulRahmanAlHamali commented Sep 23, 2016

kisdaniel commented Sep 23, 2016

shlomiassaf commented Sep 23, 2016 •

edited

shlomiassaf commented Sep 23, 2016

JulioC commented Sep 23, 2016

webartistkb commented Oct 5, 2016

JulioC commented Oct 6, 2016 •

edited

AbdulRahmanAlHamali commented Oct 6, 2016

naveenprincep commented Oct 12, 2016

JulioC commented Oct 12, 2016 •

edited

naveenprincep commented Oct 13, 2016

Romanchuk commented Nov 15, 2017

micheltank commented Dec 25, 2017 •

edited

micheltank commented Dec 25, 2017

dbrezoev commented Feb 15, 2018

bhattbhaskar commented May 11, 2018

angular2-modal: EXCEPTION: Uncaught (in promise): undefined #188

angular2-modal: EXCEPTION: Uncaught (in promise): undefined #188

Comments

kisdaniel commented Sep 13, 2016

patriknil90 commented Sep 13, 2016

AbdulRahmanAlHamali commented Sep 15, 2016

kisdaniel commented Sep 15, 2016

JulioC commented Sep 21, 2016 • edited

andyrue commented Sep 22, 2016

shlomiassaf commented Sep 22, 2016

JulioC commented Sep 22, 2016

AbdulRahmanAlHamali commented Sep 23, 2016

kisdaniel commented Sep 23, 2016

shlomiassaf commented Sep 23, 2016 • edited

shlomiassaf commented Sep 23, 2016

JulioC commented Sep 23, 2016

webartistkb commented Oct 5, 2016

JulioC commented Oct 6, 2016 • edited

AbdulRahmanAlHamali commented Oct 6, 2016

naveenprincep commented Oct 12, 2016

JulioC commented Oct 12, 2016 • edited

naveenprincep commented Oct 13, 2016

Romanchuk commented Nov 15, 2017

micheltank commented Dec 25, 2017 • edited

micheltank commented Dec 25, 2017

dbrezoev commented Feb 15, 2018

bhattbhaskar commented May 11, 2018

JulioC commented Sep 21, 2016 •

edited

shlomiassaf commented Sep 23, 2016 •

edited

JulioC commented Oct 6, 2016 •

edited

JulioC commented Oct 12, 2016 •

edited

micheltank commented Dec 25, 2017 •

edited