You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pinterest_embed_timer is an interval ID, so you'll always get an error, even if the embed is successful, if the ID pool is over 100 (pretty common, especially in SPA).
I'm not sure what this is supposed to be checking, but even if you use a counter here instead, 100 * 250ms (25 seconds) seems too long. Something like 20, or 5s total, would be more reasonable.
Also, I'm reasonably certain that the setInterval call here:
If the
pinistrify
function,handlePinterestEmbed
makes this check:embedo/embedo.js
Line 1593 in 46c7821
pinterest_embed_timer
is an interval ID, so you'll always get an error, even if the embed is successful, if the ID pool is over 100 (pretty common, especially in SPA).I'm not sure what this is supposed to be checking, but even if you use a counter here instead, 100 * 250ms (25 seconds) seems too long. Something like 20, or 5s total, would be more reasonable.
Also, I'm reasonably certain that the setInterval call here:
embedo/embedo.js
Line 1578 in 46c7821
should be inside the setTimeout after the if block containing the
PinUtils.build
call:embedo/embedo.js
Lines 1580 to 1584 in 46c7821
(after line 1583)
My changes here https://github.com/nborko/embedo/blob/865fcbe1da62467a333d31838541c39861294c48/embedo.js#L1578-L1598 work for me, please let me know if you'd like a PR.
thanks,
Nick
The text was updated successfully, but these errors were encountered: