Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function name should be lowercase #1

Closed
alichtman opened this issue Jul 5, 2018 · 2 comments
Closed

Function name should be lowercase #1

alichtman opened this issue Jul 5, 2018 · 2 comments

Comments

@alichtman
Copy link
Contributor

https://github.com/shobrook/ast-lib/blob/f2f9fcda479773b9cfd0274eb07739e42a6df45b/lib/algorithms.py#L293
@alichtman
Copy link
Contributor Author

Unless Call is a proper noun.

Maybe ignore this? idk, your call

@shobrook
Copy link
Owner

shobrook commented Jul 8, 2018

That class inherits from ast.NodeVisitor, and my definition of visit_Call is overriding theirs. So nah, it's not my call, and it's not your call – it's the ast module's call.

@shobrook shobrook closed this as completed Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shobrook @alichtman