-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Does not remove old results on refresh #16
Comments
Hey @usernotnull |
Hey @shoedler, Took me some time to figure out the issue; below is a step-by-step reproduction:
![]()
Waiting for auto-refresh does not work. The only way is to completely close Obsidian and reopen it. |
Hey again - thanks for your detailed reproduction steps. |
I've actually found a bug in the old cache system. You couldn't have e.g. identical headings in separate files show up in the suggestions, since the one that was indexed last overrode the previous keys. So I've refactored the cache system some more and added a subtitle to the suggestions which show the file source. There's still some minor issues with the new approach. For example, if you have a heading in a file with the same name as the filename, it'd override the possible suggestion for a file. Same goes for tags. I'll keep it like this until I find a better solution, since the new implementation is pretty fast. |
Here's the new "Insider" build: |
@shoedler If you need me to test it before public release, let me know when everything is implemented so I can thoroughly test it through the final draft of the insider build 👍🏼 |
@usernotnull Thanks for your offer! I'm pretty confident about the system except for the issues recorded in #22. |
Fixed in Release 1.3.0 |
Clicking on the Scroll into View button does not work most of the time.
I tried to change the theme or Reading/Edit view, but it didn't help.
Same issue with "Go to Source" for the suggestions. It opens the correct file but does not scroll to the occurrence (unless that is by design, but it's hard to know where in the source the word is). The "go to source" should in theory open the file and scroll to the word to find if the occurrence is meaningful.
** Edit: I have pinpointed the issue of the Scroll into View of the first case. Scrolling does not work if the word is found inside a callout quote.
The text was updated successfully, but these errors were encountered: