Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add direct react export to package.json #1050

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Add direct react export to package.json #1050

merged 1 commit into from
Dec 7, 2022

Conversation

ajmchambers
Copy link
Contributor

fixes #1049

@vercel
Copy link

vercel bot commented Dec 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
shoelace ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 2:23PM (UTC)

claviska
claviska approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@claviska claviska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@claviska claviska merged commit 1428481 into shoelace-style:next Dec 7, 2022
@ajmchambers ajmchambers deleted the patch-1 branch December 7, 2022 14:24
@BasyaLipman
Copy link

Seems like there is some issue here - tests are failing in the pipeline

@claviska
Copy link
Member

claviska commented Dec 7, 2022

I think this was the test runner bugging out. The subsequent build was green.

https://github.com/shoelace-style/shoelace/actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claviska claviska claviska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create React App doesn't work out of the box with Shoelace
3 participants
@ajmchambers @BasyaLipman @claviska