Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sl-input spellcheck attribute isn't honored #1061

Closed
thdoan opened this issue Dec 8, 2022 · 1 comment
Closed

sl-input spellcheck attribute isn't honored #1061

thdoan opened this issue Dec 8, 2022 · 1 comment
Assignees
@claviska
Labels
bug Things that aren't working right in the library.

Comments

@thdoan
Copy link

thdoan commented Dec 8, 2022

Describe the bug

Spellchecking is still enabled for <sl-input spellcheck="false"> elements.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://codepen.io/thdoan/pen/eYKXrgj?editors=1000
  2. Enter "aaabb" in the input box
  3. See error (you should see a red squiggly to indicate the word is misspelled)

Screenshots

image

Browser / OS

  • OS: Windows
  • Browser: Chrome
  • Browser version: 108
@thdoan thdoan added the bug Things that aren't working right in the library. label Dec 8, 2022
@claviska
Copy link
Member

claviska commented Dec 8, 2022

Thanks for the report. Fixed for <sl-input> and <sl-textarea> in 1ff05c4. I also added tests to prevent regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claviska claviska

Labels
bug Things that aren't working right in the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claviska @thdoan