Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zh-tw translations #1086

Merged
merged 3 commits into from Jan 3, 2023
Merged

add zh-tw translations #1086

merged 3 commits into from Jan 3, 2023

Conversation

sowiner
Copy link
Contributor

@sowiner sowiner commented Dec 23, 2022

新增正體中文翻譯

@vercel
Copy link

vercel bot commented Dec 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
shoelace ✅ Ready (Inspect) Visit Preview Jan 1, 2023 at 0:07AM (UTC)

@claviska
Copy link
Member

Thanks! A new term was added recently that's missing from this PR. Would you mind adding it? Let me know if you have any trouble with it, as it's the first term that uses a function instead of a string for translating. See numOptionsSelected from the English translation in next.

const translation: Translation = {

  // ...

  numOptionsSelected: (num: number) => {
    if (num === 0) return 'No options selected';
    if (num === 1) return '1 option selected';
    return `${num} options selected`;
  },

  // ...

};

@claviska claviska added the needs response Waiting for a response or feedback from the user. label Dec 28, 2022
@sowiner
Copy link
Contributor Author

sowiner commented Jan 1, 2023

Okay thank you!

Copy link
Member

@claviska claviska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@claviska claviska merged commit 377dbe2 into shoelace-style:next Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs response Waiting for a response or feedback from the user.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants