Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

min and max are not working in sl-input type date #1224

Closed
fbecker-complex opened this issue Mar 6, 2023 · 2 comments
Closed

min and max are not working in sl-input type date #1224

fbecker-complex opened this issue Mar 6, 2023 · 2 comments
Assignees
@claviska
Labels
bug Things that aren't working right in the library.

Comments

@fbecker-complex
Copy link
Contributor

Describe the bug

Since one of the last updates sl-input type="date" is no longer supporting the min and max properties correctly.
They don't seem to affect the pickable date range at all anymore.
I'm currently running shoelace in version [v2.1.0](https://github.com/shoelace-style/shoelace/releases/tag/v2.1.0)

Demo

https://codepen.io/RandyRanderson/pen/ZEMJLEv?editors=1000

Screenshots

image

Browser / OS

  • Browser: Chrome & Firefox
@fbecker-complex fbecker-complex added the bug Things that aren't working right in the library. label Mar 6, 2023
@claviska
Copy link
Member

claviska commented Mar 6, 2023

Thanks for reporting this. The bug was a regression that appeared in 2.0.0-beta.88 due to c216cfe.

Fixed in 6aaf17b. This will be available in the next release!

@fbecker-complex
Copy link
Contributor Author

Thanks for reporting this. The bug was a regression that appeared in 2.0.0-beta.88 due to c216cfe.

Fixed in 6aaf17b. This will be available in the next release!

Thank you for the quick reply.
Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claviska claviska

Labels
bug Things that aren't working right in the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claviska @fbecker-complex