Added tests to the sl-animated-images component #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
claviska
approved these changes
Mar 20, 2023
|
|
||
| describe('<sl-animated-image>', () => { | ||
| it('should render a component', async () => { | ||
| const el = await fixture(html` <sl-animated-image></sl-animated-image> `); | ||
| const animatedImage = await fixture(html` <sl-animated-image></sl-animated-image> `); |
There was a problem hiding this comment.
Nice. I like seeing this over el everywhere. Makes things easier to read. Might be worth adding to #1223.
yuki24
pushed a commit
to yuki24/shoelace
that referenced
this pull request
May 28, 2023
Co-authored-by: Dominikus Hellgartner <dominikus.hellgartner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added a few more tests