Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the tutorial for Rails #1258

Merged
merged 8 commits into from Jun 1, 2023
Merged

Update the tutorial for Rails #1258

merged 8 commits into from Jun 1, 2023

Conversation

yuki24
Copy link
Contributor

@yuki24 yuki24 commented Mar 20, 2023

As per the conversation on Discord, I'm taking a stab at it. This is still WIP, but any feedback greatly appreciated.

cc @KonnorRogers

@vercel
Copy link

vercel bot commented Mar 20, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shoelace ✅ Ready (Inspect) Visit Preview May 28, 2023 2:07am

@claviska claviska marked this pull request as draft March 20, 2023 16:31
@claviska
Copy link
Member

Thanks! I converted this to a draft, but feel free to unflag it whenever it's ready.

KonnorRogers
KonnorRogers reviewed Apr 1, 2023
View reviewed changes
Copy link
Collaborator

@KonnorRogers KonnorRogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good so far. Obviously a fleshed out section on syncing shoelace icons would be good. Mostly small minor grammatical stuff.

docs/tutorials/integrating-with-rails.md Outdated Show resolved Hide resolved
docs/tutorials/integrating-with-rails.md Outdated Show resolved Hide resolved
docs/tutorials/integrating-with-rails.md Show resolved Hide resolved
docs/tutorials/integrating-with-rails.md Outdated Show resolved Hide resolved
docs/tutorials/integrating-with-rails.md Outdated Show resolved Hide resolved
docs/tutorials/integrating-with-rails.md Outdated Show resolved Hide resolved
@claviska claviska changed the title WIP: Update the tutorial for Rails Update the tutorial for Rails Apr 4, 2023
@claviska
Copy link
Member

Thanks, @KonnorRogers. Do those suggestions look good to you, @yuki24?

@yuki24
Copy link
Contributor Author

yuki24 commented Apr 17, 2023

Thank you all for the suggestions! @claviska All great suggestions, and I think it may take a bit more time to write up a doc for importmaps. Stay tuned...

@claviska
Copy link
Member

claviska commented May 25, 2023 •
edited

I think it may take a bit more time to write up a doc for importmaps. Stay tuned...

@yuki24 Did you want that to be part of this PR or a separate one? Let me know if you need this reviewed again.

yuki24 and others added 7 commits May 28, 2023 11:06
@yuki24 @KonnorRogers
Update docs/tutorials/integrating-with-rails.md
4e3d82a 
Co-authored-by: Konnor Rogers <konnor5456@gmail.com>
@yuki24 @KonnorRogers
Update docs/tutorials/integrating-with-rails.md
31c80c2 
Co-authored-by: Konnor Rogers <konnor5456@gmail.com>
@yuki24 @KonnorRogers
Update docs/tutorials/integrating-with-rails.md
35b62bb 
Co-authored-by: Konnor Rogers <konnor5456@gmail.com>
@yuki24 @KonnorRogers
Update docs/tutorials/integrating-with-rails.md
d936925 
Co-authored-by: Konnor Rogers <konnor5456@gmail.com>
@yuki24 @KonnorRogers
Update docs/tutorials/integrating-with-rails.md
29beab5 
Co-authored-by: Konnor Rogers <konnor5456@gmail.com>
@yuki24
Update docs/tutorials/integrating-with-rails.md
e976ff2
@yuki24
Add a bit more explanation to set up icons
b1302b0
@yuki24
Copy link
Contributor Author

yuki24 commented May 28, 2023

Did you want that to be part of this PR or a separate one? Let me know if you need this reviewed again.

Let's just merge this PR without the import maps stuff. I will send a new one for that.

@yuki24 yuki24 marked this pull request as ready for review May 28, 2023 02:07
@claviska
Copy link
Member

@KonnorRogers did you want to do a final review on this before we merge?

@KonnorRogers
Copy link
Collaborator

@claviska id prefer not to waste more of @yuki24 's time. Happy to merge and fix up if needed. But I would say 🛳️ it.

@claviska claviska merged commit f966ba9 into shoelace-style:next Jun 1, 2023
2 checks passed
@yuki24 yuki24 deleted the rails-doc branch June 1, 2023 21:36
KonnorRogers added a commit that referenced this pull request Jun 12, 2023
@yuki24 @KonnorRogers
Update the tutorial for Rails (#1258)
b2f4788 
* Update the tutorial for Rails

* Update docs/tutorials/integrating-with-rails.md

Co-authored-by: Konnor Rogers <konnor5456@gmail.com>

* Update docs/tutorials/integrating-with-rails.md

Co-authored-by: Konnor Rogers <konnor5456@gmail.com>

* Update docs/tutorials/integrating-with-rails.md

Co-authored-by: Konnor Rogers <konnor5456@gmail.com>

* Update docs/tutorials/integrating-with-rails.md

Co-authored-by: Konnor Rogers <konnor5456@gmail.com>

* Update docs/tutorials/integrating-with-rails.md

Co-authored-by: Konnor Rogers <konnor5456@gmail.com>

* Update docs/tutorials/integrating-with-rails.md

* Add a bit more explanation to set up icons

---------

Co-authored-by: Konnor Rogers <konnor5456@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredcwhite jaredcwhite jaredcwhite left review comments

@KonnorRogers KonnorRogers KonnorRogers left review comments

@claviska claviska claviska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuki24 @claviska @KonnorRogers @jaredcwhite