Fix compatibility with Turbo Drive & Shoelace's autoloader #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yuki24
changed the title
claviska
approved these changes
May 17, 2023
|
Thanks for the PR. Moving the observer to |
jeysonj2
pushed a commit
to circular-o/circular
that referenced
this pull request
May 23, 2023
jeysonj2
added a commit
to circular-o/circular
that referenced
this pull request
May 23, 2023
This reverts commit b3f5dd0.
jeysonj2
added a commit
to circular-o/circular
that referenced
this pull request
May 23, 2023
This reverts commit b3f5dd0.
KonnorRogers
pushed a commit
that referenced
this pull request
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the observer used to auto-load unleaded Shoelace components, so that this will be compatible with Turbo Drive.
I am sure that 99% of the time the existing autoloader implementation works fine, but Turbo Drive replaces the
<body>tag upon page render, which in turn discards the observer. Because of this, Shoelace's autoloader stops working once a page transition occurs.I know we don't have to monitor the
<html>tags as well as<head>and<meta>tags, but hopefully this doesn't add any noticeable overhead... Let me know if there is anything I should change (e.g. testing).