Split panel tests #1343
Merged
Split panel tests #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2023 23:30
test for horizontal arrangement
tests for vertical arrangement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
jeysonj2
pushed a commit
to circular-o/circular
that referenced
this pull request
May 26, 2023
* Added tests for sl-split-panel test for horizontal arrangement * Added tests for sl-split-panel tests for vertical arrangement --------- Co-authored-by: stefanie.hellgartner <stefanie.hellgartner@in-tech.com>
jeysonj2
added a commit
to circular-o/circular
that referenced
this pull request
May 26, 2023
* update form control guidelines * reflect size; fixes shoelace-style#1348 * Split panel tests (shoelace-style#1343) * Added tests for sl-split-panel test for horizontal arrangement * Added tests for sl-split-panel tests for vertical arrangement --------- Co-authored-by: stefanie.hellgartner <stefanie.hellgartner@in-tech.com> * update changelog --------- Co-authored-by: Cory LaViska <cory@abeautifulsite.net> Co-authored-by: dhellgartner <116464099+dhellgartner@users.noreply.github.com> Co-authored-by: stefanie.hellgartner <stefanie.hellgartner@in-tech.com>
jeysonj2
added a commit
to circular-o/circular
that referenced
this pull request
May 26, 2023
* update form control guidelines * reflect size; fixes shoelace-style#1348 * Split panel tests (shoelace-style#1343) * Added tests for sl-split-panel test for horizontal arrangement * Added tests for sl-split-panel tests for vertical arrangement --------- Co-authored-by: stefanie.hellgartner <stefanie.hellgartner@in-tech.com> * update changelog --------- Co-authored-by: Cory LaViska <cory@abeautifulsite.net> Co-authored-by: dhellgartner <116464099+dhellgartner@users.noreply.github.com> Co-authored-by: stefanie.hellgartner <stefanie.hellgartner@in-tech.com>
github-actions bot
pushed a commit
to circular-o/circular
that referenced
this pull request
May 26, 2023
# [1.1.0-next.1](v1.0.3...v1.1.0-next.1) (2023-05-26) ### Bug Fixes * **docs:** getting the version from package.json in metadata.js ([#15](#15)) ([e34cbc5](e34cbc5)) ### Features * syncs Shoelace next ([4b2ffa3](4b2ffa3)), closes [shoelace-style#1348](https://github.com/circular-o/circular/issues/1348) [shoelace-style#1343](https://github.com/circular-o/circular/issues/1343)
jeysonj2
pushed a commit
to circular-o/circular
that referenced
this pull request
May 26, 2023
* Added tests for sl-split-panel test for horizontal arrangement * Added tests for sl-split-panel tests for vertical arrangement --------- Co-authored-by: stefanie.hellgartner <stefanie.hellgartner@in-tech.com>
jeysonj2
pushed a commit
to circular-o/circular
that referenced
this pull request
May 26, 2023
# [1.1.0-next.1](v1.0.3...v1.1.0-next.1) (2023-05-26) ### Bug Fixes * **docs:** getting the version from package.json in metadata.js ([#15](#15)) ([e34cbc5](e34cbc5)) ### Features * syncs Shoelace next ([4b2ffa3](4b2ffa3)), closes [shoelace-style#1348](https://github.com/circular-o/circular/issues/1348) [shoelace-style#1343](https://github.com/circular-o/circular/issues/1343)
github-actions bot
pushed a commit
to circular-o/circular
that referenced
this pull request
May 26, 2023
# [1.1.0](v1.0.3...v1.1.0) (2023-05-26) ### Bug Fixes * **docs:** getting the version from package.json in metadata.js ([#15](#15)) ([e34cbc5](e34cbc5)) ### Features * syncs Shoelace next ([4b2ffa3](4b2ffa3)), closes [shoelace-style#1348](https://github.com/circular-o/circular/issues/1348) [shoelace-style#1343](https://github.com/circular-o/circular/issues/1343)
KonnorRogers
pushed a commit
that referenced
this pull request
Jun 12, 2023
* Added tests for sl-split-panel test for horizontal arrangement * Added tests for sl-split-panel tests for vertical arrangement --------- Co-authored-by: stefanie.hellgartner <stefanie.hellgartner@in-tech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for sl-split-panel
The only thing I could not test is setting the primary panel as the fixture works only for lit/stencil elements so it is hard to wrap it in say a div which then could change size