Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sl-rating sometimes not resetting correctly when using `precisi… #1877

Conversation

cyantree
Copy link
Contributor

PR for #1802.

I think the both event handlers @mouseenter aren't needed as the base element already has one.
However only removing the event handlers didn't do the trick for me but adding pointer-events did.

I don't know why that is but here's a hypothesis:

  • The rating elements are the ones that get swapped out when fiddling with the mouse.
  • By disabling the pointer events for them the mouse has no interaction with them.
  • Therefore entering and leaving the mouse only gets handled by the parent element which never gets removed.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shoelace ✅ Ready (Inspect) Visit Preview Feb 19, 2024 6:27pm

Copy link
Member

@claviska claviska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and it's working great. Thanks for diving into this and submitting a solid PR!

@claviska claviska merged commit 6440387 into shoelace-style:next Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants