Opening Dialog should not scroll the page

[silverwind]

Describe the bug

Maybe it's only a issue on the demo page, but I noticed Dialog scrolls the page to offset 0 every time it's being opened, which is disruptive to the user.

To Reproduce

1. Go to https://shoelace.style/components/dialog
2. Scroll down a bit
3. Click on 'Open Dialog'
4. Notice that the page in the background scrolls to offset 0

Browser / OS

• OS: MacOS 14
• Browser: Firefox, Chrome
• Browser version: latest

[tylantz]

The same behaviour exists on drawers

To Reproduce

• Go to: https://shoelace.style/components/drawer#customizing-initial-focus
• Click on 'Open Drawer'
• Notice that the page in the background scrolls to offset 0

Browser / OS

• OS: Win 11
• Browser: Firefox, Chrome, Edge
• Browser version: latest

[KonnorRogers]

Should be fixed in #1967

[KonnorRogers]

Wow. This was actually a docs site only issue and required a very exact series of events:

https://twitter.com/RogersKonnor/status/1785043661882818620

html, body {
  height: 100%;
}

body { overflow-x: hidden }

.sl-scroll-lock {
  overflow: hidden;
}