Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<sl-tab-group> indicator is missing on initially disabled tabs #403

Closed
neischlah opened this issue Apr 7, 2021 · 1 comment
Closed

<sl-tab-group> indicator is missing on initially disabled tabs #403

neischlah opened this issue Apr 7, 2021 · 1 comment
Assignees
@claviska
Labels
bug Things that aren't working right in the library.

Comments

@neischlah
Copy link

Describe the bug
Tabs which are disabled initially will not show an indicator when they become active.

To Reproduce
https://jsfiddle.net/3uqm9wyt/
Wait for the second tab to get enabled, then click on it.

  1. Create a tab group in which a <sl-tab> has the disabled attribute set.
  2. Remove the attribute after some time
  3. Click on the previously disabled tab

Expected behavior
The tab indicator should appear on this tab, too.

Screenshots
image
image
@neischlah neischlah added the bug Things that aren't working right in the library. label Apr 7, 2021
@claviska
Copy link
Member

claviska commented Apr 7, 2021

Thanks for reporting this and for the fiddle — that made it easy to track down. Fixed in 8f8cf96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claviska claviska

Labels
bug Things that aren't working right in the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claviska @neischlah