Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in SlColorPicker and SlAlert #425

Closed
mcjazzyfunky opened this issue Apr 24, 2021 · 2 comments
Closed

Bugs in SlColorPicker and SlAlert #425

mcjazzyfunky opened this issue Apr 24, 2021 · 2 comments
Assignees
@claviska
Labels
bug Things that aren't working right in the library.

Comments

@mcjazzyfunky
Copy link

mcjazzyfunky commented Apr 24, 2021 •
edited
Loading

These two bugs literally drove me crazy:
Shouldn't I see two red color pickers and two open alerts here?
https://jsbin.com/vaconedeju/edit?html,output
@mcjazzyfunky mcjazzyfunky added the bug Things that aren't working right in the library. label Apr 24, 2021
@claviska
Copy link
Member

claviska commented Apr 24, 2021 •
edited
Loading

It looks like initial properties aren't being respected whereas initial attributes are. I'll have to look into this. Posting this fiddle as a minimal repro:

https://jsfiddle.net/claviska/mnL20o93/

@claviska
Copy link
Member

claviska commented May 3, 2021

This was caused by the watch decorator not running before first update. This was intended to be an optimization, but it's not really necessary and obviously causes problems when properties are set programmatically before the element is registered. Fixed in 4c1e077.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claviska claviska

Labels
bug Things that aren't working right in the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claviska @mcjazzyfunky