Multiple components are potentially broken when removing from the DOM and adding them back

[ex37]

Hi @claviska, am duplicating my follow up message for #443 into a separate issue, cause looks like you missed it.

I spent some time and reviewed other occurrences where firstUpdated is used, and just by looking at the code (haven't tried to reproduce any of these), here is what I found:

https://github.com/shoelace-style/shoelace/blob/next/src/components/icon-button/icon-button.ts#L41

focusVisible.observe(this.button); should be moved to connectedCallback

https://github.com/shoelace-style/shoelace/blob/next/src/components/rating/rating.ts#L66
https://github.com/shoelace-style/shoelace/blob/next/src/components/details/details.ts#L68

exactly same issue

https://github.com/shoelace-style/shoelace/blob/next/src/components/tooltip/tooltip.ts#L103

this.popover = new Popover(this.target, this.positioner); should be moved to connectedCallback,
as well as all of the event listeners. Maybe also this.target = this.getTarget();, not sure about this one, but overall in the current state I find tooltip component not enought dynamic and ended up wraping it into my own one. If you are interested I can collaborate my thoughts on this component.

https://github.com/shoelace-style/shoelace/blob/next/src/components/textarea/textarea.ts#L141
this.resizeObserver.observe(this.input); should be moved

https://github.com/shoelace-style/shoelace/blob/next/src/components/tab-group/tab-group.ts#L65
this.resizeObserver.observe(this.nav); and the creation of this.mutationObserver should be moved

[claviska]

Thanks for taking the time to go through these. A lot of this is probably left over from the original Stencil conversion. I've addressed all of the issues you've mentioned above and reworked a few others in b0921b5.

am duplicating my follow up message for #443 into a separate issue, cause looks like you missed it

This was fixed for dropdown in d7bf0bd.

this.popover = new Popover(this.target, this.positioner); should be moved to connectedCallback

The popover utility was removed in d720121, so that was already fixed.