Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lit-html #546

Closed
nsisodiya opened this issue Sep 28, 2021 · 5 comments
Closed

Remove lit-html #546

nsisodiya opened this issue Sep 28, 2021 · 5 comments
Assignees
Labels
bug Things that aren't working right in the library.

Comments

@nsisodiya
Copy link
Contributor

I see lots of code where lit-html is being used like this

import { classMap } from 'lit-html/directives/class-map.js';

But, AFAIK, these things are there in lit package too. like

import {classMap} from 'lit/directives/class-map.js';

Am I missing something?

@nsisodiya nsisodiya added the bug Things that aren't working right in the library. label Sep 28, 2021
@claviska
Copy link
Member

Good observation. Those are leftover since before Lit 2 and it's on my internal backlog to update the imports. I can probably get to it later this week unless you're interested in submitting a PR.

@nsisodiya
Copy link
Contributor Author

@claviska let me make a PR.

@nsisodiya
Copy link
Contributor Author

@claviska - plz let me know if something missing - #547 I am doing the first time on this repo so I might miss something.
npm run test was successful after my changes.

@nsisodiya
Copy link
Contributor Author

@claviska - may you do a PR review.

@claviska
Copy link
Member

Fixed in #547. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

2 participants