Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual thumb mode in <sl-range> #616

Closed
Kimi-Gao opened this issue Dec 10, 2021 · 3 comments
Closed

Dual thumb mode in <sl-range> #616

Kimi-Gao opened this issue Dec 10, 2021 · 3 comments
Assignees
Labels
feature Feature requests.

Comments

@Kimi-Gao
Copy link

Kimi-Gao commented Dec 10, 2021

What issue are you having?

I found that <sl-range> doesn't support dual thumb mode that will be helpful to me, could you please consider about this feature?

Describe the solution you'd like

looks like:
image

Describe alternatives you've considered

No

@Kimi-Gao Kimi-Gao added the feature Feature requests. label Dec 10, 2021
@claviska
Copy link
Member

This will require a refactor of <sl-range> since it uses <input type="range"> under the hood. I wouldn't discount it since that would make it easier to support vertical sliders and dual thumbs. It's also not currently possible to style the thumb since that requires vendor-prefixed pseudo selectors on an element buried in the shadow DOM.

Since this is going to be rewritten anyways, might as well add dual thumbs.

@claviska
Copy link
Member

One challenge of this is making it work with the Constraint Validation API. Since the current control uses <input type="range"> under the hood, that's trivial. Dual mode means reimplementing the entire control, so we may need to wait for ElementInternals to be fully supported before taking this on.

@claviska claviska changed the title Dual thumb mode in Range Dual thumb mode in <sl-range> Nov 8, 2022
@claviska claviska modified the milestone: 3.0 (future) Nov 8, 2022
@msvi
Copy link

msvi commented Mar 4, 2023

It would be nice if a rewrite of <sl-range> could support not just two but an arbitrary number of values, similar to the MUI Slider.

@shoelace-style shoelace-style locked and limited conversation to collaborators Oct 16, 2023
@claviska claviska converted this issue into discussion #1644 Oct 16, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature Feature requests.
Projects
None yet
Development

No branches or pull requests

3 participants