-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can you add the possibility for regular links on tabs-nav? #62
Comments
Are you using the latest version? I believe this was resolved in def471e. |
Tested with beta23, but it still doesn't work in my opinion. Here's my code, in case I did something wrong:
|
Fixed in beta24. |
beta24 didn't fix this for me. But I achieved the desired behaviour with one of the following 2 approaches: A – worse: by modifying shoelace's core B – better: Another working approach is using a jQuery function $('#tab-nav a:not(".active")').on('click', function(event) {
var url = $(this).attr('href');
window.location = url;
}) |
Sorry, I totally misread that before and thought you were referring to dropdowns which was a similar issue solved in def471e. I'm glad you found a solution. I'm not too keen on tabs having different behaviors for UX reasons, but it could probably work if you made it visually obvious. In that case, the snippet you provided is pretty much what I'd recommend. Maybe target it with $('#tab-nav a[rel="external"]').on('click', function(event) {
event.preventDefault();
location.href = this.href;
}); Then apply <nav class="tabs-nav">
<a href="#tab-1" class="active">Tab 1</a>
<a href="#tab-2">Tab 2</a>
<a href="https://example.com/" rel="external">External Link</a>
</nav> |
Hi there,
I (mis-)use a tabs-nav on my site as a horizontal navigation - because it suits this case quite well :)
However, it by default prevents opening a new page on click on a tab element. Would it be possible to add such functionality oob as compared to the current behaviour, where it is designed to only show/hide certain tab content containers?
Thanks,
Oliver
The text was updated successfully, but these errors were encountered: