Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<sl-details disabled> can open/close when using keyboard navigation with screen reader #658

Closed
shaal opened this issue Jan 31, 2022 · 1 comment
Assignees
Labels
bug Things that aren't working right in the library.

Comments

@shaal
Copy link
Contributor

shaal commented Jan 31, 2022

Describe the bug

When using disabled attribute in <sl-details> component, and the screen-reader (Voice Over) is on, you can navigate to the component and open/close it even that it is disabled.

<sl-details summary="Panel Should Not Open" disabled>
  Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna
  aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
</sl-details>

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://shoelace.style/components/details?id=disabled
  2. Click on the arrow of the disabled example, and it works as expected - it won't open/close
  3. (On a Mac) Turn on Voice Over
  4. Navigate to the Disabled example of <sl-details> on that same page using the keyboard (control + option + right-arrow)
  5. When you are on the trigger Disabled > - press space
  6. You'll see that the panel opened even that it should be disabled.
    image

Demo

If the bug isn't obvious, please provide a link to a CodePen or Fiddle with a minimal reproduction. Bugs that have repros get attention faster than those that don't.

Tip: use the CodePen button on any example in the docs!

Screenshots

If applicable, add screenshots to help explain the bug.

Browser / OS

  • OS: Mac
  • Browser [Edge Chromium]
  • Browser version [99.0.1141.0]

Additional information

Provide any additional information about the bug here.

@shaal shaal added the bug Things that aren't working right in the library. label Jan 31, 2022
@claviska
Copy link
Member

claviska commented Feb 1, 2022

Thanks for reporting this. It was fixed in fbec7bd and will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

2 participants