Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<sl-split-panel>.vertical cannot be toggled (by property or attribute). #703

Closed
CetinSert opened this issue Mar 11, 2022 · 2 comments
Closed
Assignees
Labels
bug Things that aren't working right in the library.

Comments

@CetinSert
Copy link

Describe the bug

<sl-split-panel> vertical (property and attribute) cannot be toggled.

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to https://shoelace.style/components/split-panel
  2. Select any <sl-split-panel> element in developer tools so that it is $0 in console.
  3. Evaluate $0.vertical = !$0.vertical once.
  4. Evaluate $0.vertical = !$0.vertical again.

Notice issues with sizing and the component getting stuck in one orientation.

Demo

See above.

Screenshots

N/A

Browser / OS

  • OS: all
  • Browser: all
  • Browser version: all

Additional information

N/A

@CetinSert CetinSert added the bug Things that aren't working right in the library. label Mar 11, 2022
@CetinSert
Copy link
Author

CetinSert commented Mar 11, 2022

Here is a Sync℠ with a workaround using 2 <sl-split-panel>s!


@claviskasyncHTML.io is the no-reload playground I am building; I would love to invite you over from the likes of CodePen and JSFiddle. Here is more info: https://elefunc.blog/sync/ (please note a lot more happened since last post).

@claviska
Copy link
Member

The vertical toggle is working, but a couple things weren't happening:

  1. The size needed to be updated when orientation changes
  2. The grid-template-rows|columns style wasn't being unset when toggling between horizontal and vertical

This has been fixed in cff57b6 and will be available in the next release.

@CetinSert CetinSert changed the title <sl-split-panel>.vertical cannot be toggled (by property or attribute). <sl-split-panel>.vertical cannot be toggled (by property or attribute). Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

2 participants