Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<sl-avatar> cannot recover from bad image values #717

Closed
CetinSert opened this issue Mar 30, 2022 · 1 comment
Closed

<sl-avatar> cannot recover from bad image values #717

CetinSert opened this issue Mar 30, 2022 · 1 comment
Assignees
Labels
bug Things that aren't working right in the library.

Comments

@CetinSert
Copy link

CetinSert commented Mar 30, 2022

Describe the bug

See title.

To Reproduce

Steps to reproduce the behavior:

  1. Go to this sync.
  2. Replace the already selected x with l (bad → good).
    You have just set the property: ❌ no image in the first avatar!
  3. Press CTRL + ALT + I.
    You have just reloaded the output: image displays in the first avatar.

  4. Replace the selected l with x (good → bad).
  5. Replace the selected x with l again (bad → good): ❌ no image in the first avatar!

Demo

See the sync linked under To Reproduce.

Please note that this type of bug is not discoverable with legacy playgrounds as they only use reloads which reset state on each edit.

Screenshots

See above.

Browser / OS

  • OS: all
  • Browser: all
  • Browser version: latest stable of all

Additional information

N/A.

@CetinSert CetinSert added the bug Things that aren't working right in the library. label Mar 30, 2022
@claviska
Copy link
Member

Thanks for reporting this. The issue can also be replicated by setting the image property to an invalid image and then setting it to a valid one.

This has been fixed in ee1a0c2 and will be available in the next release.

@CetinSert CetinSert changed the title sl-avatar cannot recover from bad image values <sl-avatar> cannot recover from bad image values Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

2 participants