Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove icon dependencies #765

Closed
ex37 opened this issue May 27, 2022 · 2 comments
Closed

remove icon dependencies #765

ex37 opened this issue May 27, 2022 · 2 comments
Assignees
Labels
feature Feature requests.

Comments

@ex37
Copy link

ex37 commented May 27, 2022

What issue are you having?

In my particular case, sl-menu-item is depending on 2 icons from default library - check-lg and chevron-right. The problem is, cause I am bundling shoelace myself, I can't find out upfront which icons are used for my bundled components. In fact, cause icons are loaded dynamically, I can't add hash to the filenames when using my bundler.

Describe the solution you'd like

There is some inconsistency currently, but some components are directly including there icons (even though they are also available in default library). The caret icon, in case of sl-button, for example. Generally I am happier with this behavior.

Describe alternatives you've considered

An alternative solution, maybeeee, would be importing icons with import statements, so that the bundler can better decide what to do, and we don't end up with duplicates.

@ex37 ex37 added the feature Feature requests. label May 27, 2022
@claviska
Copy link
Member

All icons used internally must use the system icon library. This was an oversight, but has been corrected in 9e747e7.

@ex37
Copy link
Author

ex37 commented May 27, 2022

thanks, doing same locally fixed my issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requests.
Projects
None yet
Development

No branches or pull requests

2 participants