Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome - Disabled sl-icon-button propagates click events #781

Closed
SabineWren opened this issue Jun 5, 2022 · 1 comment
Closed

Chrome - Disabled sl-icon-button propagates click events #781

SabineWren opened this issue Jun 5, 2022 · 1 comment
Assignees
@claviska
Labels
bug Things that aren't working right in the library.

Comments

@SabineWren
Copy link

Bug

sl-icon-button propagates click events when disabled, while sl-button stops them. It seems like Chrome doesn't call the internal click handler for sl-icon-button.

Demo

Codepen

Browser / OS

Chromium 99 / desktop Linux
Chrome 102 / Windows 10
Firefox works fine on both systems.
@SabineWren SabineWren added the bug Things that aren't working right in the library. label Jun 5, 2022
@claviska
Copy link
Member

claviska commented Jun 6, 2022

The event you're seeing was bubbling up from the icon element inside the icon button. Normal buttons have pointer-events: none which prevents that, so I've made icon button consistent with that behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claviska claviska

Labels
bug Things that aren't working right in the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claviska @SabineWren