Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast stack default position should be reversed in RTL mode #785

Closed
oliversalzburg opened this issue Jun 9, 2022 · 1 comment
Closed

Toast stack default position should be reversed in RTL mode #785

oliversalzburg opened this issue Jun 9, 2022 · 1 comment
Assignees
@claviska
Labels
bug Things that aren't working right in the library.

Comments

@oliversalzburg
Copy link
Contributor

Describe the bug

I haven't actually verified this, but I assume that the toast stack position is not reversed in RTL mode, based on the code.

https://github.com/shoelace-style/shoelace/blob/next/src/themes/_utility.css#L11 doesn't seem to have customization for RTL.

To Reproduce

I'm not sure how to easily force RTL mode on arbitrary examples, like in CodePen, but https://shoelace.style/components/alert should be able to illustrate it.
@oliversalzburg oliversalzburg added the bug Things that aren't working right in the library. label Jun 9, 2022
@claviska
Copy link
Member

claviska commented Jun 9, 2022

Fixed in 9b39c90.

@claviska claviska closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claviska claviska

Labels
bug Things that aren't working right in the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claviska @oliversalzburg