Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on Autoprefixer #8

Closed
claviska opened this issue Jul 31, 2017 · 5 comments
Closed

Thoughts on Autoprefixer #8

claviska opened this issue Jul 31, 2017 · 5 comments
Labels
planning Discussion about the project's upcoming features and more.

Comments

@claviska
Copy link
Member

Now that we switched to PostCSS for minification, it may be time to consider using Autoprefixer too. I don't think there's anything that's unsupported in target browsers at the moment, but for future use it's probably a good idea.

Not sure how much weight this will add to the lib — probably not too much.

I think the target should be last two browser versions. Any other options I should consider?

Thoughts?

@claviska claviska added the planning Discussion about the project's upcoming features and more. label Jul 31, 2017
@malchata
Copy link

this is a very easy add, but the hard part with autoprefixer is deciding what query you want to use. Optionally, you could leave it prefixless and advise users to process it on their own, but that makes it less friendly out of the box.

@claviska
Copy link
Member Author

I was hoping you'd chime in on this, thanks :)

It may be worth experimenting with at least, even if we decide against it after.

Users who want IE support (any version) need to use Myth for handling CSS vars. Myth also does prefixing, so basically we don't need to worry about folks who want IE support.

Knowing that, I'm OK with using the last two versions preset. Is there anything else I'm not thinking about in terms of Autoprefixer? Seems pretty straight forward, but I've only used it in as a gulp plugin with a couple basic settings before.

@malchata
Copy link

malchata commented Jul 31, 2017

This is the query I tend to use on my projects:
"last 2 versions", "> 5%", "ie > 10", "iOS >= 8"

That said, I haven't updated it in some time, but I feel this is reasonable. I can add it if you want.

@claviska
Copy link
Member Author

If you wanna take a stab at it I'd love to see the result. It would give me more confidence knowing it will resolve a lot of edge cases as we move toward stable.

@claviska
Copy link
Member Author

claviska commented Aug 1, 2017

Merged with #10

@claviska claviska closed this as completed Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
planning Discussion about the project's upcoming features and more.
Projects
None yet
Development

No branches or pull requests

2 participants